Skip to content

fix(golf): improve card selection and layout stability#189

Merged
aaylward merged 2 commits into
mainfrom
golf_ux
Mar 8, 2026
Merged

fix(golf): improve card selection and layout stability#189
aaylward merged 2 commits into
mainfrom
golf_ux

Conversation

@aaylward

@aaylward aaylward commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • No more layout jump when drawing cards — drawn card pile slot is always reserved with invisible placeholder
  • Gold pulsing glow on selected cards replaces subtle green border, clearly visible on face-down cards
  • Swap button disabled when no card selected (was enabled but showed a toast on click)
  • Turn indicator labels ("your turn" / "their turn") added to player list header with enhanced active glow

Test plan

  • Draw from deck — piles area should not shift/jump
  • Take from discard — same, no layout reflow
  • Select a face-down card during swap phase — gold pulsing border should be clearly visible
  • Verify swap button is greyed out until a card is selected
  • Check "your turn" / "their turn" labels appear correctly in player header
  • Test on mobile — responsive sizes for reserved pile slot

🤖 Generated with Claude Code

@aaylward @claude
fix(golf): improve card selection visibility and prevent layout shifts
2118879 
- Reserve drawn card pile slot to prevent layout jump when drawing
- Use gold border + pulse animation for selected cards (visible on face-down)
- Disable swap button when no card selected instead of showing toast
- Add "your turn" / "their turn" labels to player list header
- Enhance active player indicator with glow effect

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Mar 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs		 muchq 69c2360 Commit Preview URL

Branch Preview URL		 Mar 08 2026, 09:00 PM

@aaylward @claude
fix(golf): fix type errors in auth test file
69c2360 
Remove unused afterEach import, use globalThis instead of global,
and cast getGameState mock to satisfy generic type constraint.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@aaylward aaylward enabled auto-merge (squash) March 8, 2026 21:00
@aaylward aaylward merged commit 545472f into main Mar 8, 2026
2 checks passed
@aaylward aaylward deleted the golf_ux branch March 8, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aaylward